-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(robot-server): Wire up global error recovery setting #16416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we're here, fix a bug where error recovery could be enabled for OT-2s by providing an explicit error recovery policy.
sfoster1
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me
Resolve conflicts in robot-server/tests/runs/test_run_data_manager.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-719.
Test Plan and Hands on Testing
PATCH
ing theenabled
setting tofalse
, newly-created runs should fail when they encounter a defined error liketipPhysicallyMissing
.PATCH
ing theenabled
setting totrue
, or afterDELETE
ing it (resetting it to the default), newly-created runs should enter error recoverChangelog
PATCH /errorRecovery/settings
HTTP API so it actually affects run behavior. This closes EXEC-719.One quirk to my implementation:
This will not affect preexisting runs, unless you also do
PUT /runs/{id}/errorRecoveryPolicy
. In effect,PUT /runs/{id}/errorRecoveryPolicy
refreshes the run's snapshot of/errorRecovery/settings
. This is probably confusing; it would be better ifPATCH /errorRecovery/settings
immediately affected the preexisting run, or ifPUT /runs/{id}/errorRecoveryPolicy
did not have that refresh effect.I don't think this matters in practice because this button will be disabled or inaccessible in our UIs while there's an active run.
Also fix a couple of nearby, unticketed bugs:
error_recovery_mapping.py
was unintentionally enabling error recovery on OT-2 robots if the policy was specific enough. We want it to always be disabled on OT-2s.Review requests
None in particular.
Risk assessment
Medium: this area needs manual testing.