feat(app): Add partial tip support to Error Recovery #16447
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RSQ-161
Overview
This PR adds partial tip support during Error Recovery flows, specifically for tip pick-up during overpressure error recovery. After talks with design, users will be unable to select wells themselves if using a partial tip layout, since this helps prevents unexpected pickups. There are some special-cased copy updates, too.
The main files of interest are
SelectTips
, which is what's shown in the video/screenshot below,TwoColLwInfoAndDeck
,TipSelection
, andWellSelection/index.tsx
. Everything else is just adding supportive utils and refactoring things a bit.Screen.Recording.2024-10-09.at.2.05.29.PM.mov
Nozzle layout used: 8-channel with partial column, 3 nozzles
Same nozzle layout as above, demonstrating the case in which there are more nozzles than tips.
Test Plan and Hands on Testing
Changelog
Risk assessment
I'll say it's lowish-medium but this has a lot of permutations that need testing to be really confident.