Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add partial tip support to Error Recovery #16447

Draft
wants to merge 7 commits into
base: edge
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 9, 2024

Closes RSQ-161

Overview

This PR adds partial tip support during Error Recovery flows, specifically for tip pick-up during overpressure error recovery. After talks with design, users will be unable to select wells themselves if using a partial tip layout, since this helps prevents unexpected pickups. There are some special-cased copy updates, too.

The main files of interest are SelectTips, which is what's shown in the video/screenshot below, TwoColLwInfoAndDeck, TipSelection, and WellSelection/index.tsx. Everything else is just adding supportive utils and refactoring things a bit.

Screen.Recording.2024-10-09.at.2.05.29.PM.mov

Nozzle layout used: 8-channel with partial column, 3 nozzles

Screenshot 2024-10-09 at 2 28 35 PM

Same nozzle layout as above, demonstrating the case in which there are more nozzles than tips.

Test Plan and Hands on Testing

  • Smoke tested a few different parital layouts including partial column on the 8-channel, row config on the 96ch, column config on the 96ch, and single tip on the 96 ch. It is picking in the correct locations!

Changelog

  • Added partial tip support to Error Recovery.

Risk assessment

I'll say it's lowish-medium but this has a lot of permutations that need testing to be really confident.

@mjhuff mjhuff requested a review from a team October 9, 2024 19:18
@mjhuff mjhuff requested a review from a team as a code owner October 9, 2024 19:18
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 October 9, 2024 19:18
@mjhuff mjhuff marked this pull request as draft October 9, 2024 19:33
@mjhuff
Copy link
Contributor Author

mjhuff commented Oct 9, 2024

I've noticed during testing that we do actually need to supply the active nozzle here. Will fix and then re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant