fix(app): fix WellSelection over-render #16457
Merged
+38
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a rendering issue with
WellSelection
, in whichallSelectedWells
for multi-channel pipettes is computed by passing each key ofselectedTipLocations
intogetWellSetForMultichannel
. Although some of the internal logic for that util has changed recently, it's always been true thatgetWellSetForMultichannel
returns all the relevant wells given just one well, so we don't need to iterate over allselectedPrimaryWells
with areduce
.This over-render isn't an obvious problem until we introduced partial tip configs. Note this PR doesn't contain partial tip support, but we'll have to be more intentional about specifying just the well of interest when we do support partial tip configs (in the very very near future).
Before
8-channel with 3 active nozzles. E1 is the active well and the
selectedPrimaryWells
are C12-E12.After
Same config as in the before image.
Test Plan and Hands on Testing
Risk assessment
low