Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix WellSelection over-render #16457

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 10, 2024

Overview

Fixes a rendering issue with WellSelection, in which allSelectedWells for multi-channel pipettes is computed by passing each key of selectedTipLocations into getWellSetForMultichannel. Although some of the internal logic for that util has changed recently, it's always been true that getWellSetForMultichannel returns all the relevant wells given just one well, so we don't need to iterate over all selectedPrimaryWells with a reduce.

This over-render isn't an obvious problem until we introduced partial tip configs. Note this PR doesn't contain partial tip support, but we'll have to be more intentional about specifying just the well of interest when we do support partial tip configs (in the very very near future).

Before

Screenshot 2024-10-10 at 1 11 23 PM

8-channel with 3 active nozzles. E1 is the active well and the selectedPrimaryWells are C12-E12.

After

Screenshot 2024-10-10 at 1 08 58 PM

Same config as in the before image.

Test Plan and Hands on Testing

  • See images.
  • Verified this doesn't break the QT Source/Dest well component.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner October 10, 2024 17:34
@mjhuff mjhuff requested a review from smb2268 October 10, 2024 17:37
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice change!

@mjhuff
Copy link
Contributor Author

mjhuff commented Oct 10, 2024

Apologies for the quick merge. Need this for the very very near future partial tip PR.

@mjhuff mjhuff merged commit 3254494 into edge Oct 10, 2024
20 checks passed
@mjhuff mjhuff deleted the app_fix-wellselection-rendering branch October 10, 2024 18:30
mjhuff added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants