fix(gripper): capacitive sensor task should use correct sensor ID #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caila-marashaj
force-pushed
the
RQA-2760-flex-gripper-reports-wrong-sensor-id-during-calibration
branch
from
4f91a00
to
1b65ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The S1 sensor has been falsely using the wrong ID while responding to CAN messages.
This is because the sensor ID for the driver is defaulted to S0, and we rely on
set_sensor_id()to update the sensor. We've made these changes for the pipettes (#630). And sinceshared_sensoris always false for the gripper, we've never set the sensor ID for S1.