Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sensors): remove USE_SENSOR_FIRMWARE compile target #790

Merged
merged 9 commits into from
Jul 8, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Jul 2, 2024

Overview

We want to keep the SENSOR_MOVE option, but get rid of sensor firmware build variants. We also want to make what was previously the USE_SENSOR_MOVE if-define in the sensor drivers the default option, so we can get rid of some of the ifdefs for now.

For the pressure sensor, reporting will no longer happen continuously over the CAN bus as long as the report binding is set. It will use the circular buffer which has a default size of 500, and send over all of the data that buffer has only in response to a SendAccumulatedSensorDataRequest.

The capacitive sensor, for now, will keep the old reporting functionality, which is reporting continuously as long as the report bit is set, as well as have a circular buffer and populate that if report is true.

In the future, we'll want to probably have more parity between the sensors' data repoting also pull out the "circle buffer" functionality into its own class.

Changelog

  • get rid of -sensor firmware variants
  • remove the sensors option from the push script
  • remove sensor-preset related github workflows
  • make the capacitive sensor's logging a little more like the pressure sensor's to temporarily make up for these other changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool. nice work!

@caila-marashaj caila-marashaj merged commit a2c4b6c into main Jul 8, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants