refactor(sensors): remove USE_SENSOR_FIRMWARE compile target #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We want to keep the
SENSOR_MOVE
option, but get rid of sensor firmware build variants. We also want to make what was previously theUSE_SENSOR_MOVE
if-define in the sensor drivers the default option, so we can get rid of some of theifdef
s for now.For the pressure sensor,
reporting
will no longer happen continuously over the CAN bus as long as thereport
binding is set. It will use the circular buffer which has a default size of 500, and send over all of the data that buffer has only in response to aSendAccumulatedSensorDataRequest
.The capacitive sensor, for now, will keep the old
reporting
functionality, which is reporting continuously as long as thereport
bit is set, as well as have a circular buffer and populate that ifreport
is true.In the future, we'll want to probably have more parity between the sensors' data repoting also pull out the "circle buffer" functionality into its own class.
Changelog
-sensor
firmware variantssensors
option from thepush
script