Add Social Profile #45
Conversation
|
@kushthedude Thanks |
|
@NishithP2004 Thanks |
|
@snitin315 Can you please merge my PR? |
|
@cweitat I have update index.html file. Can you please review it again? |
index.html
Outdated
| @@ -591,6 +591,12 @@ <h2>Klaikong Vaidhyakarn</h2> | |||
| <a target="default" href="https://www.facebook.com/misako.ito"> | |||
| <i class="icon social_facebook"></i> | |||
| </a> | |||
| <a target="default" href="https://twitter.com/misako_ito"> | |||
There was a problem hiding this comment.
This is not even her. Can you check before you even make the changes?
index.html
Outdated
| @@ -1555,6 +1567,9 @@ <h1>Team</h1> | |||
| <a href="https://github.com/mishari" target="default"> | |||
| <i class="icon fa fa-github"></i> | |||
| </a> | |||
| <a href="https://www.youtube.com/user/misharim" target="default"> | |||
|
Don't just make a PR for the sake of it. If you don't check before updating, just close this PR. |
|
@cweitat Sorry for that mistake, I haven't check carefully. Can you please review it again. I have check it very careful. If it didn't get merged, I will close this PR. Again sorry for wasting your time. |
|
@snitin315 Can you please review it? |
|
@snitin315 Can you please review it again? |
To Squash your commits Refer here |
|
You can leave the squashing part. |
|
@kushthedude Can you please review it again? |
index.html
Outdated
| @@ -621,11 +624,14 @@ <h2>Misako Ito</h2> | |||
| </a> | |||
| <a target="default" href="https://m.facebook.com/putchonguth?fref=nf"> | |||
| <i class="icon social_facebook"></i> | |||
| </a> | |||
| <a target="default" href="https://www.youtube.com/user/pxu007"> | |||
index.html
Outdated
| </a> | ||
| <a target="default" href="https://sites.google.com/a/ku.th/putchong-uth/home"> | ||
| <i class="icon fa fa-external-link"></i> | ||
| </a> | ||
| <a target="default" href="https://www.cpe.ku.ac.th/?page_id=1959"> | ||
| <a target="default" href="https://www.cpe.ku.ac.th/?page_id=1959"> |
| <a href="https://www.linkedin.com/in/jinalfoflia" target="default"> | ||
| <i class="icon social_linkedin"></i> | ||
| </a> | ||
| <a target="default" href="https://medium.com/@jinalfoflia"> |
There was a problem hiding this comment.
why post a link that is old from 3 years ago and not updated?
| @@ -1692,7 +1710,10 @@ <h2>Sivalee Anantachart</h2> | |||
| </a> | |||
| <a target="_self" href="github.com/mariobehling"> | |||
| <i class="icon fa fa-github"></i> | |||
| </a> | |||
| </a> | |||
| <a href="https://www.youtube.com/user/mariobehling" target="default"> | |||
There was a problem hiding this comment.
what's the purpose? how is it relevant to the event??
This is the work for this issue: #44.
I have added links to various social profile of some of the speakers in the Fossasia OpenTechSummit Thailand. I also update some of the social profile of the Fossasia Team. I also change linkedin profile of MR. Andrew Lee because it linking to the collabora company.
The deployment link: https://hoangdatngo.github.io/thai.opentechsummit.asia/
@mariobehling, @hpdang. Can any mentor please review my PR?