Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.9 #40

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

V3.9 #40

wants to merge 55 commits into from

Conversation

yugaa22
Copy link
Collaborator

@yugaa22 yugaa22 commented Sep 9, 2021

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

ramyaravi-opsmx and others added 10 commits July 16, 2021 12:18
Op 7120 v3.9 - By pass the authentication for v5 approval gate trigger API
Op 6746 v3.9 - Enabled prometheus metrics
enable prometheus metrics config added
* custom plugin adding while creating image

* custom plugin adding while creating image
@opsmxuser
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FF5APCVVRGPTK4P4M9CDDC3G

@opsmxuser
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

1 similar comment
@opsmxuser
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FFFF0AZ9ZDYAXYK29ZSF4NCA

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FFFF0AZ92K0TW58G4363JCZK

sriharshakancharla and others added 6 commits October 11, 2021 20:00
OP-7390: Bug fix for cloud provider response failed status return
… issues (#85) (#86)

* OP-10214: Using RetryOnExceptionAuthManager to handle LDAP connection issues (#84)

* OP-10214: Using RetryOnExceptionAuthManager to handle LDAP connection issues

* OP-10214: Added tests

* OP-10214: Moved code to appropriate packages

* OP-10214: Moved the packages
@gopaljayanthi
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@gopaljayanthi
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQ13CCPMQ0ZTKE3DHRTXJSWN

@gopaljayanthi
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@gopaljayanthi
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQ14R5C33QS8801C1SQYY3ZJ

@gopaljayanthi
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@gopaljayanthi
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQGS7W1TM8RJP3RM27FAGYW5

@gopaljayanthi
Copy link
Collaborator

RunTestJar RESULT: Total tests run: 257, Failures: 22, Skips: 0 Reviewers , please check that the changes in this PR did not cause the failures in http://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-1506.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants