Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made change in PrometheusHealthIndicatorTest class #14

Merged

Conversation

vivek-opsmx
Copy link
Collaborator

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

@vivek-opsmx
Copy link
Collaborator Author

vivek-opsmx commented Nov 27, 2023

Issue wrt commit :- PrometheusHealthIndicatorTest test case was failing due to

  1. For downWhenHealthStatusesEmpty Test case error was org.mockito.exceptions.misusing.UnnecessaryStubbingException: Unnecessary stubbings detected.
  2. For upWhenHealthStatusesAreAllUp The failure message was indicates that the test expected the health status to be UP for both "service1" and "service2," but the actual result was DOWN with the reason
    Solution :
  3. for downWhenHealthStatusesEmpty added lenient()
  4. the fix is it correctly handles the scenario where all health statuses are UP and constructs the Health object accordingly

@sanopsmx sanopsmx merged commit 77e94de into OpsMx:OES-1.30.1 Nov 27, 2023
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants