Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for holding a button on boot to wait for programmer. #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xC0000005
Copy link

Not sure if this would be useful to other people, but at least the PR can be searched for. Trying to upload to a cricut via PIO or arduino, I kept hitting timeouts, so I added a def for a button which, if held down, causes it to wait forever for programming. The cricut has buttons low when on, but both are supported.

If it's useful, I could probably create #ifdef blocks for the other pins/ports.

@mcuee
Copy link

mcuee commented Oct 22, 2022

This seems to be useful.


#else
#error -------------------------------------------
#error Unrecognized LED name. Should be like "B5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is incorrect wording probably an effect of cut&paste. Can you re-word please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll change it (and yeah, it's cut and paste).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants