Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad-hoc sign Mac builds #602

Merged

Conversation

OverloadedOrama
Copy link
Member

This should solve the "Pixelorama is damaged" error on macOS, as suggested by #516 (comment).

@bruvzg
Copy link

bruvzg commented Dec 1, 2021

Signing did not work correctly since app have non-executable files (pixelorama_data folder) in the MacOS subfolder, theses should go into the Resources subfolder instead. Also, icon seems to be replaced after signing instead of doing it before.

Signature check log:

~ % codesign -vvvv ./Pixelorama.app

./Pixelorama.app: a sealed resource is missing or invalid
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/vline_3x3.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Grass/~Grass4.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Grass/~Grass5.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Grass/~Grass1.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Grass/~Grass2.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Grass/~Grass3.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/circle_blended.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Snow.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Star/~star5.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Star/~star4.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Star/~star6.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Star/~star3.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Star/~star2.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/Star/~star1.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/pixelorama_icon.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/hline_3x3.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Brushes/godot_icon.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Metro_tile.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Gravel.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Yellow_Marble.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Purple_Texture.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/White_Marble.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/small_stonebricks.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/wooden_planks_2.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Wooden_planks_1.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Ground_leaves.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Brick.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Patterns/Light_Blue_Texture.png
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Palettes/Triad.tres
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Palettes/BubbleGum16.tres
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Palettes/Shades.tres
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Palettes/Monochromatic.tres
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Palettes/Default.tres
file added: /Users/bruv/Downloads/Pixelorama.app/Contents/MacOS/pixelorama_data/Palettes/Complementary.tres
file modified: /Users/bruv/Downloads/Pixelorama.app/Contents/Resources/icon.icns

@OverloadedOrama
Copy link
Member Author

Okay, I think I may have fixed it now.

@bruvzg
Copy link

bruvzg commented Dec 1, 2021

Okay, I think I may have fixed it now.

Now it's working as expected, with can't check it for malicios software popup, and can be started by clicking Open Anyway it the Security & Privacy setting page.

@OverloadedOrama
Copy link
Member Author

Awesome, I will go ahead and merge then. Thank you for your help!

@OverloadedOrama OverloadedOrama merged commit 0259f75 into Orama-Interactive:master Dec 1, 2021
@OverloadedOrama OverloadedOrama deleted the ad-hoc-sign branch April 24, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants