Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8773: Recompiling client-side assets on 1.10.x #8779

Merged
merged 20 commits into from
Apr 16, 2024
Merged

8773: Recompiling client-side assets on 1.10.x #8779

merged 20 commits into from
Apr 16, 2024

Conversation

BenedekFarkas
Copy link
Member

@BenedekFarkas BenedekFarkas commented Apr 4, 2024 •
edited
Loading

Ready for review

Related to the #8773 issue, this is prerequisite of the #8774 PR.

List of changes:

@BenedekFarkas
Updating rebuilt client-side assets that only changed in terms of sou…
7226b06 
…rceMappingURL
@BenedekFarkas
Updating rebuilt client-side assets that changed functionally
13bbb43
@BenedekFarkas
Fixing/simplifying Layout editor toolbox stickyness and height restri…
c420676 
…ction to viewport
@BenedekFarkas
Merge branch '1.10.x' into issue/8773-1.10.x
266c842
@BenedekFarkas
Compile workflow: Upgrading actions/checkout and microsoft/setup-msbu…
51a9aaa 
…ild actions to their latest versions
@BenedekFarkas
Compile workflow: Adding steps to validate that the client-side asset…
dab1c22 
…s are up-to-date
@BenedekFarkas
Compile workflow: Temporarily disabling MSBuild steps
486cef8
@BenedekFarkas
Moving client-side assets build to a separate job in the compile work…
1977f16 
…flow
@BenedekFarkas
Updating client-side compilation job
e173351
@BenedekFarkas
Temporarily disabling the .NET build
2a8fef7
@BenedekFarkas
Separating package install from asset rebuild
cd1dc17
@BenedekFarkas
Adding debug command
2d8a66a
@BenedekFarkas
Fixing working directory
ff35704
@BenedekFarkas
Debugging
5c6ee92
@BenedekFarkas
Attempting to get rid of false positives due to line ending changes
89982c8
@BenedekFarkas
Removing debug code
a845478
@BenedekFarkas
Checking asset validation by modifying Orchard.Resources/Assets/Less/…
3fc9b83 
…Bootstrap/variables.less, but not its derivatives
@BenedekFarkas
Revert "Checking asset validation by modifying Orchard.Resources/Asse…
9a80dae 
…ts/Less/Bootstrap/variables.less, but not its derivatives"

This reverts commit 3fc9b83.
@BenedekFarkas
Revert "Temporarily disabling the .NET build"
8b38abc 
This reverts commit 2a8fef7.
@BenedekFarkas
Fixing error message when client-side assets are not up-to-date
594f6c2
@BenedekFarkas BenedekFarkas mentioned this pull request Apr 4, 2024
Closed
@BenedekFarkas
Copy link
Member Author

I'll merge this and move on with the 1.10.x -> dev merge and the rest of the PR cleanup.

@BenedekFarkas BenedekFarkas merged commit 530d2a9 into 1.10.x Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HermesSbicego-Laser HermesSbicego-Laser Awaiting requested review from HermesSbicego-Laser

@sebastienros sebastienros Awaiting requested review from sebastienros

@MatteoPiovanelli-Laser MatteoPiovanelli-Laser Awaiting requested review from MatteoPiovanelli-Laser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BenedekFarkas