Convert Newtonsoft converters to STJ converters #14457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
commented
Oct 8, 2023
| @@ -105,9 +77,64 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist | |||
| return contentItem; | |||
| } | |||
|
|
|||
| public override bool CanConvert(Type objectType) | |||
| public override void Write(Utf8JsonWriter writer, ContentItem value, JsonSerializerOptions options) | |||
There was a problem hiding this comment.
This is might be a temp solution I'm working to add a JTokenConverter
|
The unit tests seems to fail because an entity has a |
|
Unless here you are trying to keep the |
|
I might defer |
Merged
|
@hishamco is this still needed? If not, please close it |
|
Nope, also there's another PR from @sarahelsaig need to be deleted too |
|
Thanks for pointing it out, Hisham. I closed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #14456