Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(score-card): New config jsonNameOfAllEntities #197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

A11oW
Copy link

@A11oW A11oW commented Aug 9, 2023

Added a new parameter through which you can set the file name for all entities. In my environment.
I use gitlab for hosting score data and I plan to receive data via gitlab api (for cors to work). My work full url like this: "https://gitlab.local/api/v4/projects/6242/repository/files/all.json/raw". How can you see url have postfix /raw in my case

It seems to make it possible to make the name "all.json" customizable would not be superfluous

✔️ Checklist

  • Added tests for new functionality and regression tests for bug fixes
  • Added changeset (run yarn changeset in the root)
  • Screenshots of before and after attached (for UI changes)
  • Added or updated documentation (if applicable)

@jvilimek
Copy link
Collaborator

Hello @A11oW,

so sorry I missed your suggestion. There was (and in fact still is) an issue with PR notifications for this repo, got overwhelmed and also there was no reason to check the repo for a long time. try to ping me next time, it should help :)

Regarding your contribution... is this something you still wish to merge? There is some ongoing parallel work so we shall release a new version soon, with your changes included. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants