Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Messaging Fixes #4094

Merged
merged 3 commits into from
Dec 12, 2019
Merged

Messaging Fixes #4094

merged 3 commits into from
Dec 12, 2019

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Dec 6, 2019 •
edited
Loading

  • Show toast message when sending message fails
  • Identify and fix 4081

Checklist:

franckc
franckc approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@franckc franckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for hardening this code.

@shahthepro shahthepro merged commit 14f3189 into master Dec 12, 2019
@shahthepro shahthepro deleted the shahthepro/messaging-error-reporting branch December 12, 2019 04:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@franckc franckc franckc approved these changes

@nick nick Awaiting requested review from nick

@sparrowDom sparrowDom Awaiting requested review from sparrowDom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahthepro @franckc