Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the audit we made the following two changes:
Removed from
FixedRateRewardsSource.sol
initialize
:Added to
FixedRateRewardsSource.sol
_setRewardsPerSecond
:These make it so that when rewards are enabled on the contract, the
lastCollect
is reset to the current time, and thus no rewards will be paid out for the period when the rewards were set to zero.In other case, as before, the contract will pay out pending rewards from the lastCollect at the newly set rate. Calling collectRewards before setting the rate allows precise reward payments for past rewards.
This PR just updates the comments on this change.