Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 013 - Migrator and veOGV upgrade #438

Merged
merged 16 commits into from
Jun 18, 2024
Merged

Deploy 013 - Migrator and veOGV upgrade #438

merged 16 commits into from
Jun 18, 2024

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Jun 7, 2024

Contract Address
Migrator (Implementation) 0x936B7855c3f20b09685770467f7621AC41B03063
veOGV (Implementation) 0x5DA3E12893bB8673aC482d7177a1836c83d671F4

Deployment Checklist

  • Contracts are verified on Etherscan
  • Deployed code matches code on master
  • Contract constructor args are as expected
  • Deployer doesn't own the implementation contracts
  • Txs in Deployer address match the deploy script
  • Fork tests pass

@shahthepro shahthepro requested a review from DanielVF June 7, 2024 05:04
@naddison36
Copy link
Contributor

naddison36 commented Jun 7, 2024

  • I've verified the deployed code matches code on master
sol2uml diff 0x936B7855c3f20b09685770467f7621AC41B03063 .
Compared the "Migrator" contract with address 0x936B7855c3f20b09685770467f7621AC41B03063 on mainnet
to local files under folders "."

match   contracts/Governable.sol
match   contracts/interfaces/IStaking.sol
match   contracts/Migrator.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/ERC20.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/extensions/ERC20Burnable.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/IERC20.sol
match   lib/openzeppelin-contracts/contracts/utils/Context.sol
sol2uml diff 0x5DA3E12893bB8673aC482d7177a1836c83d671F4 .
Compared the "OgvStaking" contract with address 0x5DA3E12893bB8673aC482d7177a1836c83d671F4 on mainnet
to local files under folders "."

match   contracts/Governable.sol
match   contracts/OgvStaking.sol
match   contracts/RewardsSource.sol
match   lib/openzeppelin-contracts/contracts/governance/utils/IVotes.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/ERC20.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/extensions/draft-ERC20Permit.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/extensions/draft-IERC20Permit.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/extensions/ERC20Votes.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/extensions/IERC20Metadata.sol
match   lib/openzeppelin-contracts/contracts/token/ERC20/IERC20.sol
match   lib/openzeppelin-contracts/contracts/utils/Context.sol
match   lib/openzeppelin-contracts/contracts/utils/Counters.sol
match   lib/openzeppelin-contracts/contracts/utils/cryptography/draft-EIP712.sol
match   lib/openzeppelin-contracts/contracts/utils/cryptography/ECDSA.sol
match   lib/openzeppelin-contracts/contracts/utils/math/Math.sol
match   lib/openzeppelin-contracts/contracts/utils/math/SafeCast.sol
match   lib/openzeppelin-contracts/contracts/utils/Strings.sol
match   lib/prb-math/contracts/PRBMath.sol
match   lib/prb-math/contracts/PRBMathUD60x18.sol
  • I've verified the constructor args are correct.
  • the deployer does own the implementation contracts which is what it is being transferred to the 5/8 mutisig as part of the governance tx
  • Txs in 5/8 multisig match the deploy script

Base automatically changed from shah/deploy-tooling-updates to master June 7, 2024 06:35
@DanielVF
Copy link
Contributor

DanielVF commented Jun 8, 2024

  • Deployed code matches code on master
  • Contract constructor args are as expected
  • Txs in Deployer address match the deploy script

@shahthepro shahthepro merged commit 4dfbb17 into master Jun 18, 2024
4 checks passed
@shahthepro shahthepro deleted the shah/deploy-13 branch June 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants