Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 014 - xOGN Governance #440

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Deploy 014 - xOGN Governance #440

merged 1 commit into from
Jun 21, 2024

Conversation

shahthepro
Copy link
Collaborator

Addresses

Contract Address
Governance 0x1D3Fbd4d129Ddd2372EA85c5Fa00b2682081c9EC

Parameteres

Name Value
Initial Vote Delay 7200 blocks (~1d)
Voting Period 14416 blocks (~2d)
Proposal Threshold 100k xOGN
Late Quorum Extension 7200 blocks (~1d)

If you made a contract change, make sure to complete the checklist below before merging it in master.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@shahthepro shahthepro requested a review from DanielVF June 18, 2024 10:05
Copy link
Contributor

@DanielVF DanielVF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
  • Deployed contract's verified code (and all dependencies) match the code in master
  • The transactions that interacted with the newly deployed contract match the deploy script.

@sparrowDom
Copy link
Member

I've verified that:

  • deployed xOGN contract's source matches the one in master
  • governance proposal's transactions match the ones in migration script 14

@shahthepro do you know why the new xOGN contract is not in build/deployments/1/ folder?

@shahthepro
Copy link
Collaborator Author

@shahthepro do you know why the new xOGN contract is not in build/deployments/1/ folder?

It's not a new Contract. It's the same Governance contract that we used for OGV

@sparrowDom
Copy link
Member

Oh got it thanks

@shahthepro shahthepro merged commit eca70b7 into master Jun 21, 2024
4 checks passed
@shahthepro shahthepro deleted the shah/deploy-014 branch June 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants