Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Inlines displaying as Editable #112

Open
wants to merge 3 commits into
base: read-only-change-view
Choose a base branch
from
Open

Fixing Inlines displaying as Editable #112

wants to merge 3 commits into from

Conversation

gascarcella
Copy link

Fixed Inlines displaying as Editable on Read Only view.

We still need to get rid of the add buttons

image

@OskarPersson i hope you can take a look. I'll have some time to work on this tomorrow

@OskarPersson
Copy link
Owner

Thank you, I will look into this when I can. Also, if you want to update an existing pull request without creating a new one you can simply push to your own branch again and it will automatically be updated.

@gascarcella
Copy link
Author

Thank you, I will look into this when I can. Also, if you want to update an existing pull request without creating a new one you can simply push to your own branch again and it will automatically be updated.

Thanks and sorry for closing the last one! 1st time contributing to open source

@OskarPersson
Copy link
Owner

@gascarcella I updated your branch. I have managed to get rid of the add button. The delete checkbox is still there in the upper-right, but you can't do anything with it since the save button is not there any more. Tell me if this works for you or not :)

@OskarPersson
Copy link
Owner

@gascarcella Have you had any time to look into my updates?

@gascarcella
Copy link
Author

Hey @OskarPersson .
I'm really sorry, im busy on another project until tomorrow.
I'll have time Saturday and Sunday, and will post you an update asap.

We keep in touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants