Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close tab to the left or right #1404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close tab to the left or right #1404

wants to merge 1 commit into from

Conversation

ObserverHerb
Copy link

Vivaldi has a nice feature where you can close tabs to the left or right of the current tab. I wanted it in Otter so I added it, then figured might as well open a pull request for it.

I'd like to not show it on the left-most or right-most tabs, but I'm not sure how to get the tab count from within TabBarWidget.cpp.

Vivaldi has a nice feature where you can close all tabs to the right
of the current tab, which is increasingly popular, but also close
tabs to the left. This adds that functionality to Otter.
@Emdek
Copy link
Member

Emdek commented Sep 22, 2017

@herbmillerjr, for now we can get it pretty easily, but we need to think about plans from #190, namely tab stacking.
First we need to decide how it should behave when called on tab that belongs to stack, should it close tabs inside own group or from parent group as well?
Also we need to decide if these actions should have own identifiers or be a special variant of CloseOtherTabsAction, or some new entry but shared by both variants (any ideas how we could name it in this case?).
Last but not least, we are preparing to make that menu customizable, so the right place to handle it would be just MainWindow and working with SessionModel might be the best way to handle it (TabBarWidget is in the process of becoming the slave of SessionModel).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants