raise_flags in dataflags is always raised

[RondeauG]

Setup Information

• Xclim version: 0.44

Description

When using xclim.core.dataflags.data_flags, an exception will always be raised when raise_flags=True.

Steps To Reproduce

import numpy as np
import xclim.core.dataflags
from xclim.testing.helpers import test_timeseries as timeseries
tasmin = np.array([-15] * 365)
tasmax = np.array([15] * 365)
ds = timeseries(tasmin, "tasmin", "1/1/2000", freq="D", as_dataset=True)
ds["tasmax"] = timeseries(tasmax, "tasmax", "1/1/2000", freq="D")
flags = {"tasmax_below_tasmin": {}}
xclim.core.dataflags.data_flags(ds["tasmax"], ds, flags=flags, raise_flags=True)

Gives:

Traceback (most recent call last):
  File "/usr/local/pycharm-community-2022.2.3/plugins/python-ce/helpers/pydev/_pydevd_bundle/pydevd_exec2.py", line 3, in Exec
    exec(exp, global_vars, local_vars)
  File "<input>", line 1, in <module>
  File "/.../site-packages/xclim/core/dataflags.py", line 696, in data_flags
    raise DataQualityException(dsflags)
xclim.core.dataflags.DataQualityException: Data quality flags indicate suspicious values. Flags raised are:
  - 

Additional context

I'm pretty sure that the culprit is

xclim/xclim/core/dataflags.py

Line 695 in 7451885

if np.any(dsflags.data_vars.values()):

It currently gives:

ValuesView(Data variables:
    tasmax_below_tasmin  bool False)

Which I'm guessing gets interpreted as a True. Something like np.any([dsflags[v].values for v in dsflags.data_vars]) would give the correct False.

Contribution

• I would be willing/able to open a Pull Request to address this bug.

Code of Conduct

• I agree to follow this project's Code of Conduct