Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix raise_flags #1457

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Fix raise_flags #1457

merged 4 commits into from
Aug 17, 2023

Conversation

RondeauG
Copy link
Contributor

@RondeauG RondeauG commented Aug 16, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes the raise_flags argument of xclim.core.dataflags.data_flags so that an Exception is only raised when some checkups fail.

Does this PR introduce a breaking change?

  • No

Other information:

@github-actions github-actions bot added the approved Approved for additional tests label Aug 17, 2023
@RondeauG RondeauG merged commit cb76d3c into master Aug 17, 2023
25 checks passed
@RondeauG RondeauG deleted the fix_raise_flags branch August 17, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

raise_flags in dataflags is always raised
3 participants
@RondeauG @Zeitsperre @aulemahal