-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic Version v2.0.0 Specification #1569
Conversation
On inspection, the No further action is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
In the github action, I think you could have get the current_version and new_version using bump-my-version show
argument (see here for example), but the regex works fine too.
Joyeuses fêtes !
Pull Request Checklist:
bump2version
forbump-my-version
#1557number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
xclim
now adheres to the Semantic Versioning 2.0.0 specification.bump2version
has been replaced withbump-my-version
setup.cfg
has been deleted;flake8
configurations have migrated to.flake8
file, andbumpversion
configuration is now found inpyproject.toml
..gitignore
to properly ignore some autogenerated files.Does this PR introduce a breaking change?
Yes. The versioning system has been adjusted so that patch versions are not augmented at every push to
xclim
code; instead, the build version is adjusted.Other information:
https://callowayproject.github.io/bump-my-version/