Block-mapped resample with the help of flox #1848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
changed the title
Zeitsperre
reviewed
Jul 26, 2024
for more information, see https://pre-commit.ci
This reverts commit a7e5bde.
This reverts commit 9778739.
aulemahal
changed the title
Zeitsperre
approved these changes
Sep 6, 2024
|
|
||
| Returns | ||
| ------- | ||
| clean_obj : |
Comment on lines
+32
to
+35
| try: | ||
| import flox | ||
| except ImportError: | ||
| flox = None |
There was a problem hiding this comment.
Would it be better if we were adding flox to the tox configuration, then parametrizing the tests to use flox if it's there? I believe we have one build that tests the extras recipe already.
There was a problem hiding this comment.
Yes, but my current "testing" only consist in hijacking an existing test and enabling the new option in a certain case. A importorskip('flox') would be much better, but I'll do that on a test specific to resample_map. To come in the next working days...
There was a problem hiding this comment.
Okay, that sounds fine to me! Just keep it in mind.
Co-authored-by: Trevor James Smith <[email protected]>
for more information, see https://pre-commit.ci
Zeitsperre
reviewed
Sep 6, 2024
There was a problem hiding this comment.
I have an alternative suggestion here (and would save me from opening a PR):
- Add
flox(with a baseline pin version) to theextrasrecipe. - Add
floxandpot >=0.9.4to theenvironment.yml. - Add
fastnanquantile >=0.0.2to theenvironment.ymlsection for pip dependencies. - Remove
floxfrom the DEP001 list.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Implements
resample_map. This function is meant for allda.resample(...).map(...)calls. These,floxcannot improve automatically so we use some flox logic to help. The idea is to map the resample-map construct on each block in parallel. This is possible by first rechunking the array so that chunks boundary fit with resampling period boundaries (this is a flox function).The main improvement should come from the fact that
map_blockshides much of the complexity todask, so the resulting graph is much lighter. I still have to better test the performance of this. My goal would be to have some short text in xclim's doc that highlights when the option is useful and when it is not. The option is activated throughset_options.The current function works only when the input object is of the same type as the output one. So some functions couldn't be wrapped with this yet. The most important untouched code for the moment is the missing checks where I think this could help a lot.
Does this PR introduce a breaking change?
It should not. This is completely optional.
Other information:
In progress, I still need to prove the performance boost.
This depends on #1845 because I need all improvements for PC.