Standardized Streamflow Index and Standardized Groundwater level Index #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LamAdr
changed the title
LamAdr
commented
Aug 12, 2024
tests/test_indices.py
Outdated
| @@ -751,6 +751,54 @@ def test_standardized_precipitation_evapotranspiration_index( | |||
|
|
|||
| np.testing.assert_allclose(spei.values, values, rtol=0, atol=diff_tol) | |||
|
|
|||
| # reference results: Obtained with R package `standaRdized` | |||
There was a problem hiding this comment.
@SarahG-579462 @coxipi
I couldn't find any other reference to test against for SSI (same for SGI I think). I could only replicate two conditions out of many. When the values get too far from zero, standaRdized outputs lots of NaNs and the non-NaNs are far away from us. Also in these replicable values, the offset is somewhat constant.
It looks like the problem is on their side?
Do you think this is still a valuable test then?
I'll also add a couple tests against ourselves.
LamAdr
commented
Aug 13, 2024
Zeitsperre
reviewed
Aug 13, 2024
Co-authored-by: Trevor James Smith <[email protected]>
Co-authored-by: Trevor James Smith <[email protected]>
Co-authored-by: Trevor James Smith <[email protected]>
Co-authored-by: Trevor James Smith <[email protected]>
|
Where things stand
|
|
Just an FYI, but some tests are expected to fail until #1889 is merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information: