Use caching to speed up testdata fetching, fix upstream builds, scipy suggestions #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note It appears that this Pull Request modifies the On inspection, the No further action is required. |
|
This is ready. Will perform a |
aulemahal
approved these changes
Sep 16, 2024
Zeitsperre
changed the title
### What kind of change does this PR introduce? * Applies several linting suggestions adopted by the `scipy` community * Replaces `isort` with `ruff` formatting * Adds Markdown file formatting * Adds a few strongly encouraged `ruff` checks (`bugbear`, `pyupgrade`) * Adjust `mypy` checks ### Does this PR introduce a breaking change? Yes. `isort` is no longer required. Code checks are marginally stricter. ### Other information: https://github.com/scientific-python/repo-review If we wanted to replace `black` as well, this is feasible with `ruff`, as it nearly replicates its functionality 1-to-1. To be revisited. I've staged the `python-check-blanket-noqa` and `python-check-blanket-type-ignore` hooks since there are several instances where these won't work (`numba`-based code blocks). These statements should be followed up on at some point, likely when we address more things with `mypy`.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
sdba
Zeitsperre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
pipdependencies, thetoxenvironments and thexclim-testdatacache to speed up the CI setup on subsequent builds.Does this PR introduce a breaking change?
No.
Other information:
https://github.com/actions/cache
Preliminary results suggest that this will shave at least 30 seconds off of the setup times for most builds (except for
prefetch-basedtoxenvironments, as this build is designed to test the fetching of the test data).Also worth noting: Caches are immutable once created!