Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstring of frost free spell max length #1977

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Fix docstring of frost free spell max length #1977

merged 5 commits into from
Oct 30, 2024

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Oct 29, 2024 •
edited by Zeitsperre
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fix the "choices" of parameter op in the docstring of frost_free_spell_max_length.

Does this PR introduce a breaking change?

No. This should not affect most users. Only users using the indicator.parameters[...].choices explicitly would be affected, for example : finch.

Other information:

@github-actions github-actions bot added the indicators Climate indices and indicators label Oct 29, 2024
@github-actions github-actions bot added the approved Approved for additional tests label Oct 29, 2024
@coveralls
Copy link

coveralls commented Oct 30, 2024 •
edited
Loading

Coverage Status

coverage: 89.377%. remained the same
when pulling 210f44b on fix-ff-spell-max
into d5dcf88 on main.

@aulemahal aulemahal merged commit f8bb400 into main Oct 30, 2024
21 checks passed
@aulemahal aulemahal deleted the fix-ff-spell-max branch October 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlogan2000 tlogan2000 tlogan2000 approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aulemahal @coveralls @tlogan2000 @Zeitsperre