Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure Container Instances guidance #20

Merged
merged 31 commits into from
Dec 5, 2023
Merged

Add Azure Container Instances guidance #20

merged 31 commits into from
Dec 5, 2023

Conversation

jonathanalgar
Copy link
Member

No description provided.

@jonathanalgar jonathanalgar self-assigned this Oct 5, 2023
@jonathanalgar jonathanalgar changed the title Update Dockerfile & add Azure AZI guidance Update Dockerfile & add Azure Container Instances guidance Oct 6, 2023
joaomvalentim
joaomvalentim requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@joaomvalentim joaomvalentim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have agreed that we should not include specific container runtimes here like azure, and rather have technical docs with examples. So the Dockerfile change is ok, it makes the command clearer, but the doc part regarding ACI should not be included here.

@joaomvalentim
Copy link
Collaborator

This PR addresses two things:

  • Dockerfile fix
  • Documentation updates for Azure ACI.
    Can we please split this to be able to approve only the first one?

@jonathanalgar jonathanalgar changed the title Update Dockerfile & add Azure Container Instances guidance Add Azure Container Instances guidance Oct 9, 2023
@jonathanalgar jonathanalgar removed the request for review from jmunoz19 October 9, 2023 20:31
@jonathanalgar
Copy link
Member Author

We've changed track and will work on this content in a new document.

@joaomvalentim joaomvalentim reopened this Oct 17, 2023
jonathanalgar
jonathanalgar commented Oct 19, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
bmartins-unit
bmartins-unit requested changes Nov 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
bmartins-unit
bmartins-unit previously approved these changes Nov 30, 2023
View reviewed changes
joaomvalentim
joaomvalentim requested changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@joaomvalentim joaomvalentim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ACI section

README.md Outdated Show resolved Hide resolved
joaomvalentim
joaomvalentim previously approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@joaomvalentim joaomvalentim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bmartins-unit
bmartins-unit previously approved these changes Dec 5, 2023
View reviewed changes
@jonathanalgar jonathanalgar force-pushed the update-azure-aci-guidance branch from 6d87c9d to 743f94f Compare December 5, 2023 15:39
@bmartins-unit bmartins-unit merged commit b2d7f03 into main Dec 5, 2023
3 checks passed
@bmartins-unit bmartins-unit deleted the update-azure-aci-guidance branch December 5, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmartins-unit bmartins-unit bmartins-unit approved these changes

@OS-kiranmalsetty OS-kiranmalsetty OS-kiranmalsetty left review comments

@joaomvalentim joaomvalentim joaomvalentim left review comments

Assignees

@jonathanalgar jonathanalgar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanalgar @joaomvalentim @bmartins-unit @OS-kiranmalsetty