Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guide] Completed recommended soundfonts section #21

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

GreenWeegeeCantCode
Copy link
Contributor

This one took quite a while to make, i put 5 amazing soundfonts for the section.
Also i just noticed that dependabot updated mkdocs material to 9.5.6, sorry if it breaks anything.

dependabot bot and others added 4 commits January 29, 2024 22:00
Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.5.3 to 9.5.6.
- [Release notes](https://github.com/squidfunk/mkdocs-material/releases)
- [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG)
- [Commits](squidfunk/mkdocs-material@9.5.3...9.5.6)

---
updated-dependencies:
- dependency-name: mkdocs-material
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…material-9.5.6

Bump mkdocs-material from 9.5.3 to 9.5.6
In this one, i added 5 amazing soundfonts, here are the ones i added:
Arachno
KSP
K-Bass Deluxe 4
Amethyst Imperial Grand
KKCG4
Copy link
Collaborator

@6gh 6gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thank you for creating this. Right now I am on mobile so I will merge it later but I've left some feedback you might want to look over in the meantime.

> TODO: im not sure what soundfonts would be good. someone pls take over
## Arachno

Arachno is a really nice soundfont, it's one of the most used soundfonts in the Black MIDI Conmunity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add, "for GM sounds" at the end of this? Most of the time arachno is used for its instruments other than the default piano one. I would also like to make it clear that this should be accompanied by another soundfont like the ones you added here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

docs/OmniMIDI/Soundfonts/recommendations.md Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
@6gh 6gh linked an issue Feb 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@6gh 6gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page looks good! I will try to make preview videos for these soundfonts 👍

Thank you for the contribution once again!

@6gh 6gh changed the base branch from main to cleanup February 6, 2024 23:36
@6gh 6gh merged commit 1b28757 into OvertureMIDI:cleanup Feb 6, 2024
@6gh 6gh mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Resource] Recommended Soundfonts
2 participants