Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swctl : Implement swctl dependency commands #115

Merged
merged 8 commits into from
Sep 11, 2023

Conversation

Giluerre
Copy link
Collaborator

@Giluerre Giluerre commented Aug 28, 2023

  • adding dependency commands which allow set external dependencies
  • part 2/2 making swctl available as library, removing naming of statical texts

@Giluerre Giluerre changed the title swctl : manage external dependencies swctl : Implement swctl dependency commands Aug 28, 2023
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Show resolved Hide resolved
cmd/swctl/app/dialog.go Outdated Show resolved Hide resolved
cmd/swctl/app/dialog.go Outdated Show resolved Hide resolved
cmd/swctl/app/dialog.go Outdated Show resolved Hide resolved
cmd/swctl/app/dialog.go Outdated Show resolved Hide resolved
cmd/swctl/app/dialog.go Outdated Show resolved Hide resolved
@Giluerre Giluerre changed the title swctl : Implement swctl dependency commands WIP: swctl : Implement swctl dependency commands Sep 4, 2023
@Giluerre Giluerre changed the title WIP: swctl : Implement swctl dependency commands swctl : Implement swctl dependency commands Sep 6, 2023
cmd/swctl/app/cmd_dependency.go Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@fgschwan fgschwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please check the CI test problem and rebase your code.

cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
cmd/swctl/app/cmd_dependency.go Outdated Show resolved Hide resolved
-adding dependency commands which allow set external dependencies
-part 2/2 making swctl available as library, removing naming of statical texts

Signed-off-by: Daniel Béreš <[email protected]>
- Fixing:
 - error handling
 - description
 - adding dpdk
 - refactoring
Signed-off-by: Daniel Béreš <[email protected]>
- fix template
- delete dpdk as vpp package can handle interfaces
- Dumping interfaces based on pci

Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
@fgschwan fgschwan self-requested a review September 11, 2023 09:10
@fgschwan fgschwan merged commit 024d341 into PANTHEONtech:main Sep 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants