-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swctl : Implement swctl dependency commands #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Giluerre
commented
Aug 28, 2023
•
edited
Loading
edited
- adding dependency commands which allow set external dependencies
- part 2/2 making swctl available as library, removing naming of statical texts
Giluerre
changed the title
swctl : manage external dependencies
swctl : Implement swctl dependency commands
Aug 28, 2023
fgschwan
requested changes
Aug 28, 2023
Giluerre
changed the title
swctl : Implement swctl dependency commands
WIP: swctl : Implement swctl dependency commands
Sep 4, 2023
Giluerre
changed the title
WIP: swctl : Implement swctl dependency commands
swctl : Implement swctl dependency commands
Sep 6, 2023
fgschwan
requested changes
Sep 6, 2023
fgschwan
requested changes
Sep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please check the CI test problem and rebase your code.
-adding dependency commands which allow set external dependencies -part 2/2 making swctl available as library, removing naming of statical texts Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
- Fixing: - error handling - description - adding dpdk - refactoring Signed-off-by: Daniel Béreš <[email protected]>
- fix template - delete dpdk as vpp package can handle interfaces - Dumping interfaces based on pci Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
Signed-off-by: Daniel Béreš <[email protected]>
fgschwan
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.