Improve standalone CNF component detection #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Motičák <[email protected]>
fgschwan
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no good way to determine that a container running in StoneWork Docker Compose project is a standalone CNF. Therefore we use a heuristic: if it is not StoneWork or a StoneWork module but it still contains running instance of vpp-agent then it is a standalone CNF. For now we check only the default vpp-agent HTTP port to see if vpp-agent is running which determines if we classify it as a standalone CNF or an auxiliary container.
Also improve table output of
swctl statuscommand to show IP address and default ports of the standalone CNF.Signed-off-by: Peter Motičák [email protected]