Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra rpath entries to common macOS library install locations. #95

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

metasim
Copy link
Contributor

@metasim metasim commented Mar 18, 2024

@pomadchin Is it possible for you to publish a SNAPSHOT version so I can easily test the output from CI?

@pomadchin pomadchin added the enhancement New feature or request label Mar 18, 2024
@pomadchin
Copy link
Collaborator

Sure, will merge it in once CI is happy

@metasim

This comment was marked as outdated.

@@ -69,7 +69,8 @@ jobs:
if: steps.conda-cache.outputs.cache-hit != 'true'
run: conda install pdal=${{ matrix.pdal }}

- name: Set LD_LIBRARY_PATH
- name: Set LD_LIBRARY_PATH
if: ${{ matrix.os == 'ubuntu-latest' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More for clarity than anything else.

@pomadchin
Copy link
Collaborator

ha, what was the change to make it work?

@metasim
Copy link
Contributor Author

metasim commented Mar 18, 2024

ha, what was the change to make it work?

Basically reverting another change that I thought would eliminate an extra RC_RPATH record.

❯ otool -l  /Users/sfitch/Coding/OSS/PDAL-Java/native/target/native/arm64-darwin/bin/./libpdaljni.2.6.dylib | grep -A2 RPATH
          cmd LC_RPATH
      cmdsize 72
         path @rpath:/usr/local/lib:/opt/homebrew/lib:/opt/local/lib (offset 12)
--
          cmd LC_RPATH
      cmdsize 64
         path /opt/homebrew/Caskroom/miniconda/base/envs/pdal/lib (offset 12)

I thought I understood the setting behavior, but it was only passing locally because I relied on sbt clean rather than find . -name target -exec rm -r {} \;, as the former doesn't clean out all the cmake byproducts. See #91

@pomadchin
Copy link
Collaborator

Oh, the CMAKE_SKIP_BUILD_RPATH; cool; merging so you can try it out 👍

@pomadchin pomadchin merged commit b1a4aa0 into PDAL:main Mar 18, 2024
5 checks passed
@metasim metasim deleted the feature/extra-rpaths branch March 18, 2024 18:26
@metasim
Copy link
Contributor Author

metasim commented Mar 18, 2024

How do I find the Maven Central coordinates?

@pomadchin
Copy link
Collaborator

sonatype snapshots! (https://oss.sonatype.org/content/repositories/snapshots/io/pdal/)

Check the readme, the orange button click!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants