Add datetime in conferences cards #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microstudi
reviewed
Jan 11, 2024
microstudi
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Nice job @ElviaBth
just remove the added methods on the conference override and will be good to go!
microstudi
pushed a commit
that referenced
this pull request
Mar 5, 2024
* fix test * add datetime * add start_time and start_date method * fix overrides spec * add chromedriver-version * use start and end date * add date format * remove start and end time methods * add system test * pass rubocop * add spec system test * modify system test date fotmat * modify system test date format
microstudi
added a commit
that referenced
this pull request
Mar 6, 2024
* Triplicate conferences hacking the hashtag (#7) * add custom menu items * controller override, add routes * change add item menu * Apply suggestions from code review Co-authored-by: Ivan Vergés <[email protected]> * add options if to add_item * add rspec, refactoring * fix lint * promoted conferences override, add tests * remove global config from secret, refactoring controller's methods * change tests * add controller spec * fix robocop * move initializers and overrides to initializers folder * refactoring model and tests * Update config/locales/en.yml Co-authored-by: Ivan Vergés <[email protected]> * fix initializers * fix initialize * gitignore * add actions * add config --------- Co-authored-by: Ivan Vergés <[email protected]> * change color pallete in the css (#13) * remove additional logo (#12) * Filter conferences by colors (#14) * Replace hashtags, Remove menu "triplication" * Replace hashtags * show buttons for existing conferences * refactoring * add original to deface * cells override * use a query string * add tests * add controller spec * add spec checksums * change default links color * active links * styles * add promo video content block (#15) * add promo video content block * fix active processes cell * fix var css * update newsletter. add translations * Create a new home content block with partner logos (#16) * add content block * add logos * add logos --------- Co-authored-by: Ivan Vergés <[email protected]> * add partners to dockerfile * fix dockerfile * rebuild 1st partner * filter order & small fixes * filter order * fix promoted conferences (#17) * fix promoted conferences * css corrections * fix specs * fix logos * fix apostrophes * add premsa i programa * new program * copy fix * prevent non conferences to use hashtag hack * add omniauth decidim * update mailer styles * update pwa * latests fixes * add missing envs * Sort conferences (#19) * sort conferences * refactoring * fix order --------- Co-authored-by: Ivan Vergés <[email protected]> * fix order again * override image size media * update agenda * update newsletter & logos * fix logos * Add datetime in conferences cards (#24) * fix test * add datetime * add start_time and start_date method * fix overrides spec * add chromedriver-version * use start and end date * add date format * remove start and end time methods * add system test * pass rubocop * add spec system test * modify system test date fotmat * modify system test date format * update newsletter * update news * change decidim version * remove social share button * update package.json dependencies * add tailwind.config to .gitignore * update rubocop.yml * update migrations code * add missing mixin * remove _decidim-settings.scss * enable Custom HTML Header snippets * include conference Override * add Module Paginable to conference controllerOverride * fix lib and system specs * fix controller specs * remove PR#24 changes * assign main-footer color * apply styles to active-processes section * apply styles to newsletter button * style sub_hero text description * add styles to sub_hero button * replace mini-footer with deface * adjust mini-footer styles * fix styles loader error * replace main-footer with deface * fix styles * fix test * add homepage footer spec * add final newline to spec * modify chromedriver setup * add chromedriver-version * set up chromedriver * pass rubocop * update newletter * modify some content_blocks styles * fix partner_logos content_blocks styles * fix conferences filter * remove participatory space floting help * fix filter conferences bg class * setup chromedriver * bundle gems * change chromedriver version * change chromedriver version * add chrome version to workflow * fix test * add cards filter-conferences border-color * remove few old partners logo * add locales_languages to mobile menu * set partner logos size * fix dockerfile * fix dockerfile * fix migrations * fix migrations * add awesome preview * add margn bottom to navbar * add .rspec-failures to gitignore * remove cta-buttom override * fix hero content-block-button * change color menu * modify item color menu * design fixes * update texts * fix fonts and cells * newsletter template * logos sizes * standarize footer * prevent sql files to be commited * add scripts with cookie conf * update logo * fix logos --------- Co-authored-by: Ivan Vergés <[email protected]> Co-authored-by: Anna Topalidi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add datetime in conferences cards.
📌 Related Issues
Related to #23
📷 Screenshots
