Use petab.v1 #74
Merged
Use petab.v1 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilpath
approved these changes
Jul 1, 2024
| @@ -1,7 +1,7 @@ | |||
| from inspect import cleandoc | |||
|
|
|||
| import pandas as pd | |||
| from petab.C import * | |||
| from petab.v1.C import * | |||
There was a problem hiding this comment.
Should this already import from petab.v2?
There was a problem hiding this comment.
For now it's the same. Once they diverge more, we'll have to re-organize test generation here. I'd wait until then.
There was a problem hiding this comment.
Well, I can also just update them now.
There was a problem hiding this comment.
When things break to due missing petab.v2.C.PREEQUILIBRATION_CONDITION_ID, we'll know we have to update the tests...
There was a problem hiding this comment.
Oops, there is no petab.v2.C yet
This reverts commit d97784b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be compatible with, and require petab>=0.4.0