Add support for Spigot 1.10-1.12 #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
reviewed
Aug 7, 2023
util/src/main/java/tc/oc/pgm/util/nms/v1_10_12/NMSHacks1_10_12.java
Outdated
Show resolved
Hide resolved
Pablete1234
reviewed
Aug 11, 2023
Pablete1234
reviewed
Aug 12, 2023
Pablete1234
reviewed
Aug 12, 2023
cswhite2000
force-pushed
the
v1_10
branch
2 times, most recently
from
a56cdfb
to
02fbafd
Compare
cswhite2000
force-pushed
the
v1_10
branch
2 times, most recently
from
f6e4e1d
to
f557b19
Compare
Pablete1234
previously approved these changes
Sep 19, 2023
Signed-off-by: Christopher White <[email protected]>
Pablete1234
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1199
Leaving as a draft until that PR is merged.
Adds support for Spigot versions 1.10 - 1.12.2.
I was originally going to do this in three parts, but the changes to support 1.11 and 1.12 using the 1.10 NMSHacks were ~5 lines of code.
Same basic information as the 1.9 PR, supports everything Spigot 1.8 supports.
Next step: