Add proximity setting for auto #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ui.proximitysetting currently only allows true & false, which works allright for tournament settings to have it enabled, and more public/casual to hide it. However this poses a problem when some maps have timelimit that can end up deciding the winner based on proximity. It's not intuitive to win/lose a match and not see in the scoreboard why it was.This PR fixes it by adding an 'auto' setting to proximity, which means it will hide proximity most of the time (similar to false), with the exception of when there's an active timelimit, and the tl will use proximity to decide its result (eg: a TL with result = defenders won't show proximity). Additionally things like score-results will hide proximity, but show it during overtime as then it could end up deciding the result.