Fix comment

PHILO-HE · Jun 17, 2024 · 0bb3345 · 0bb3345
1 parent c751fc2
commit 0bb3345
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/velox/docs/functions/spark/array.rst b/velox/docs/functions/spark/array.rst
@@ -161,7 +161,7 @@ Array Functions
         SELECT shuffle(array(0, 0, 0), 0); -- [0, 0, 0]
         SELECT shuffle(array(1, NULL, 1, NULL, 2), 0); -- [2, 1, NULL, NULL, 1]
 
-.. spark:function:: size(array(E), legacySizeOfNull) -> int
+.. spark:function:: size(array(E), legacySizeOfNull) -> integer
 
     Returns the size of the array. Returns null for null input if `legacySizeOfNull`
     is set to false. Otherwise, returns -1 for null input.

diff --git a/velox/docs/functions/spark/map.rst b/velox/docs/functions/spark/map.rst
@@ -41,7 +41,7 @@ Map Functions
 
     Returns all the values in the map ``x``.
 
-.. spark:function:: size(map(K,V), legacySizeOfNull) -> int
+.. spark:function:: size(map(K,V), legacySizeOfNull) -> integer
    :noindex:
 
     Returns the size of the input map. Returns null for null input if ``legacySizeOfNull``

diff --git a/velox/functions/sparksql/Size.cpp b/velox/functions/sparksql/Size.cpp
@@ -62,9 +62,8 @@ struct Size {
       if (legacySizeOfNull_) {
         out = -1;
         return true;
-      } else {
-        return false;
       }
+      return false;
     }
     out = input->size();
     return true;