Fix comment

PHILO-HE · Jun 21, 2024 · 165a838 · 165a838
1 parent 5d0f757
commit 165a838
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/velox/core/SimpleFunctionMetadata.h b/velox/core/SimpleFunctionMetadata.h
@@ -709,13 +709,13 @@ class UDFHolder {
 
   static_assert(
       !(udf_has_call_return_bool && udf_has_call_return_void),
-      "Provided call() methods need to return either void OR bool OR status.");
+      "Provided call() methods need to return either void OR bool OR Status.");
   static_assert(
       !(udf_has_call_return_bool && udf_has_call_return_status),
-      "Provided call() methods need to return either void OR bool OR status.");
+      "Provided call() methods need to return either void OR bool OR Status.");
   static_assert(
       !(udf_has_call_return_void && udf_has_call_return_status),
-      "Provided call() methods need to return either void OR bool OR status.");
+      "Provided call() methods need to return either void OR bool OR Status.");
 
   // callNullable():
   static constexpr bool udf_has_callNullable_return_bool = util::has_method<
@@ -741,13 +741,13 @@ class UDFHolder {
       udf_has_callNullable_return_status;
   static_assert(
       !(udf_has_callNullable_return_bool && udf_has_callNullable_return_void),
-      "Provided callNullable() methods need to return either void OR bool OR status.");
+      "Provided callNullable() methods need to return either void OR bool OR Status.");
   static_assert(
       !(udf_has_callNullable_return_bool && udf_has_callNullable_return_status),
-      "Provided callNullable() methods need to return either void OR bool OR status.");
+      "Provided callNullable() methods need to return either void OR bool OR Status.");
   static_assert(
       !(udf_has_callNullable_return_void && udf_has_callNullable_return_status),
-      "Provided callNullable() methods need to return either void OR bool OR status.");
+      "Provided callNullable() methods need to return either void OR bool OR Status.");
 
   // callNullFree():
   static constexpr bool udf_has_callNullFree_return_bool = util::has_method<

diff --git a/velox/expression/tests/SimpleFunctionTest.cpp b/velox/expression/tests/SimpleFunctionTest.cpp
@@ -1548,6 +1548,7 @@ TEST_F(SimpleFunctionTest, noThrow) {
       (evaluateOnce<int64_t, int64_t>("try(no_throw(c0))", 6)),
       "Input must not be 6");
 
+  // Error reported via Status by callNullable.
   VELOX_ASSERT_THROW(
       (evaluateOnce<int64_t, int64_t>("no_throw(c0)", std::nullopt)),
       "Input cannot be NULL");