Simplify a check

PHILO-HE · Mar 15, 2024 · 6261654 · 6261654
1 parent 37f73be
commit 6261654
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/velox/exec/Window.cpp b/velox/exec/Window.cpp
@@ -285,10 +285,12 @@ void updateKRowsOffsetsColumn(
   int precedingFactor = isKPreceding ? -1 : 1;
   for (auto i = 0; i < numRows; i++) {
     auto startValue = (int64_t)(startRow + i) + precedingFactor * offsets[i];
-    if (startValue > INT32_MAX || startValue < INT32_MIN) {
-      // Integer overflow. computeValidFrames will replace INT32_MAX set here
+    if (startValue < INT32_MIN) {
+      rawFrameBounds[i] = 0;
+    } else if (startValue > INT32_MAX) {
+      // computeValidFrames will replace INT32_MAX set here
       // with partition's final row index.
-      rawFrameBounds[i] = startValue < 0 ? 0 : INT32_MAX;
+      rawFrameBounds[i] = INT32_MAX;
     } else {
       rawFrameBounds[i] = startValue;
     }