Skip to content

Commit

Permalink
Upgrade PhpUnit
Browse files Browse the repository at this point in the history
To a version which is aware that Php8.4 deprecates E_STRICT.
  • Loading branch information
oleibman committed Nov 14, 2024
1 parent db89fe2 commit 819854a
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 60 deletions.
109 changes: 55 additions & 54 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions tests/PhpSpreadsheetTests/Chart/ChartsDynamicTitleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
use PhpOffice\PhpSpreadsheet\Writer\Xlsx as XlsxWriter;
use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;

/**
* Seems to need to be separate for Php8.4 PhpUnit9 combination.
*
* @runTestsInSeparateProcesses
*/
class ChartsDynamicTitleTest extends AbstractFunctional
{
protected function tearDown(): void
Expand Down
2 changes: 1 addition & 1 deletion tests/bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function phpunit10ErrorHandler(int $errno, string $errstr, string $filename, int
return false; // continue error handling
}

if (!method_exists(PHPUnit\Framework\TestCase::class, 'setOutputCallback') || PHP_VERSION_ID >= 80400) {
if (!method_exists(PHPUnit\Framework\TestCase::class, 'setOutputCallback')) {
ini_set('error_reporting', (string) E_ALL);
set_error_handler('phpunit10ErrorHandler');
}

0 comments on commit 819854a

Please sign in to comment.