Integrate Exceptions Better with PhpStorm #3765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3754. Because
PhpSpreadsheetException
extendsException
, PhpStorm warns that calls tosetValueExplicit
andsetValue
, among others, do not handle the exception, because PhpStorm treatsException
, by default, as "checked". On the other hand, PhpStorm treatsRunTimeException
as "unchecked" so won't flag such calls. It is reasonable to letPhpSpreadsheetException
extendRuntTimeException
, and will eliminate the problem, without having to wrap code in all-but-useless try-catch blocks (e.g. forsetValue
, the code would raise an exception only if you try to set the cell's value to an unstringable object).This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.