-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Redis driver to read all keys efficiently #913
base: master
Are you sure you want to change the base?
Conversation
The Redis driver's function to read all keys has been streamlined. The changes include removing the check for iterable and adding a loop to scan and merge the keys iteratively. This ensures that the function will work correctly, even when the number of keys retrieved exceeds the MAX_ALL_KEYS_COUNT.
Where did you see that ? From which version ? |
I'm sorry for the not so good PR comment. By |
I just read this in the docs:
I now understand the purpose of this PR. I'll check it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the points above
It should be fixed. I've also made the same changed in the rediscluster driver |
Hello, thanks but the quality tools does not pass, please run them locally before pushing: https://github.com/PHPSocialNetwork/phpfastcache/blob/master/CONTRIBUTING.md#developer-notes |
Can you fix the CI @mapcentia ? |
The Redis driver's function to read all keys has been streamlined. The change is adding a loop to scan and merge the keys iteratively. This ensures that the function will work correctly, even when the number of keys scanned exceeds the MAX_ALL_KEYS_COUNT.
Proposed changes
This is a fix for #912
Types of changes
What types of changes does your code introduce to Phpfastcache?
Agreement
I have read the CONTRIBUTING and CODING GUIDELINE docs