Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uhm 8302 basic summary of most recent petl run #333

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Uhm 8302 basic summary of most recent petl run #333

wants to merge 2 commits into from

Conversation

dmdesimone
Copy link
Contributor

No description provided.

@dmdesimone dmdesimone requested a review from mseaton December 13, 2024 15:17
mseaton
mseaton reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really seem like something that belongs in the pipeline. This is just a view that will never change and should always be present, right? Can't you just create this view, potentially manually in each DW SQL Server DB?

@dmdesimone
Copy link
Contributor Author

This doesn't really seem like something that belongs in the pipeline. This is just a view that will never change and should always be present, right? Can't you just create this view, potentially manually in each DW SQL Server DB?

Awesome... can totally do that. Will just drop the script to create it somewhere. You have an opinion where to store it?

@mseaton
Copy link
Member

mseaton commented Dec 16, 2024

This doesn't really seem like something that belongs in the pipeline. This is just a view that will never change and should always be present, right? Can't you just create this view, potentially manually in each DW SQL Server DB?

Awesome... can totally do that. Will just drop the script to create it somewhere. You have an opinion where to store it?

Maybe under sql/schemas or a new folder called sql/views. That gives you the option to have a job create this view, or just to keep it there for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseaton mseaton mseaton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmdesimone @mseaton