Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC build errors #60

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Fix MSVC build errors #60

merged 1 commit into from
Jan 27, 2024

Conversation

PhoenixBound
Copy link
Collaborator

  • Link with shell32.dll in Release builds. This is needed for ShellExecute in the help dialog.
  • Add x64 platform to the solution, not just the project. We probably want to be making x64 builds now so that people on arm64 Macs can use x64 Wine, since it can't run 32-bit programs.
  • Fix a few implicit function definitions and issues with labels on declarations I found in the build output and after opening help.c in the IDE.

@PhoenixBound
Fix MSVC build errors
0d21acd 
- Link with shell32.dll in Release builds. This is needed for
  ShellExecute in the help dialog.
- Add x64 platform to the solution, not just the project
- Fix a few implicit function definitions and issues with labels on
  declarations I found
@PhoenixBound PhoenixBound merged commit 1ce1e2c into PKHackers:master Jan 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisBlueStone ChrisBlueStone ChrisBlueStone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhoenixBound @ChrisBlueStone