Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft to get a really important feature addressed. It should close #246 and possibly resolves #269 as well.
I propose two things:
update
function, and then forward the request tocreate
if the item doesn't exist, but the reverse should do fine.Doing a bulk import with these changes does still trigger the Obsidian menu to choose attachments for some of the items, but I feel like this is unavoidable and any assumptions made during import could be the wrong ones, so this part of #269 might be unavoidable.
I tried not to touch too many files, since this is all reverse-engineered from the Obsidian console. I would be happy to add/improve these changes, but I'd need some tips on building the repository.