-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging the bi-dexhands directory #17
Comments
Dear @ltzheng , Thank you for your concern! Yeah it is my bad and we also want to do this before. But I've been busy lately so haven't done QAQ.
Yeah, if you'd like to open a PR we would greatly appreciate it! Hope this can help you. |
Hi @ltzheng , We package the Bi-DexHands as your suggestions. Thank you very much! An example usage, also added in the README.md: import bidexhands as bi
import torch
env_name = 'ShadowHandOver'
algo = "ppo"
env = bi.make(env_name, algo)
obs = env.reset()
terminated = False
while not terminated:
act = torch.tensor(env.action_space.sample()).repeat((env.num_envs, 1))
obs, reward, done, info = env.step(act) Hope this can help you. |
Sorry for didn't notice your comment five days ago. |
Hi @cypypccpy |
Hi @ltzheng , Yeah I also agree. I have merged your PR, thank you for your contribution! |
It would be easier to use if you can rename the folder
bi-dexhands
tobidexhands
and add a__init__.py
to turn it into a python package.This allows directly use this package in the code. Otherwise there will be a ModuleNotFoundError when importing
bidexhands
.The
setup.py
can be updated as follows.You also need to modify several import lines inside the package, e.g., change
to
If you don't mind, I can open a pull request.
The text was updated successfully, but these errors were encountered: