-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/chunked writer precomputed burdens testing combo #135
Merged
bfclarke
merged 141 commits into
main
from
feature/chunked-writer-precomputed-burdens-testing-combo
Sep 24, 2024
Merged
Feature/chunked writer precomputed burdens testing combo #135
bfclarke
merged 141 commits into
main
from
feature/chunked-writer-precomputed-burdens-testing-combo
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/deeprvat into feature-precomputed-burden-testing
…d-writer-precompyted-burdens-testing
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
endast
reviewed
Sep 20, 2024
...eprvat/test_data/pipeline_tests/training_association_testing/models/repeat_1/best/bag_0.ckpt
Outdated
Show resolved
Hide resolved
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
HolEv
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spottet only some minor things we could still fix for consistency.
Main thing is that we have two log folder is burdens log
and logs
which we should unify. Otherwise really nice!
…o' of github.com:PMBio/deeprvat into feature/chunked-writer-precomputed-burdens-testing-combo
…o' of github.com:PMBio/deeprvat into feature/chunked-writer-precomputed-burdens-testing-combo
bfclarke
deleted the
feature/chunked-writer-precomputed-burdens-testing-combo
branch
September 24, 2024 09:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a fairly large PR that makes several changes:
deterministic
flag to the config - useful when testing results of pipeline runs.config.py
Testing
main
branch