Include stack traces in error messages

PNNL-Comp-Mass-Spec · Aug 27, 2024 · 25172d1 · 25172d1
1 parent f6abecb
commit 25172d1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/MSFileInfoScanner/Readers/MSFileInfoProcessorBaseClass.cs b/MSFileInfoScanner/Readers/MSFileInfoProcessorBaseClass.cs
@@ -1153,7 +1153,7 @@ protected void LoadScanDataWithProteoWizard(
             }
             catch (Exception ex)
             {
-                OnErrorEvent("Error using ProteoWizard reader", ex);
+                OnErrorEvent(string.Format("Error using ProteoWizard reader; {0}", StackTraceFormatter.GetExceptionStackTrace(ex)), ex);
             }
         }
 

diff --git a/MSFileInfoScanner/Readers/ProteowizardDataParser.cs b/MSFileInfoScanner/Readers/ProteowizardDataParser.cs
@@ -687,7 +687,12 @@ public bool StoreMSSpectraInfo(ProteoWizardParserInfo parserInfo)
             }
             catch (Exception ex)
             {
-                OnErrorEvent(string.Format("Error reading instrument data with ProteoWizard: {0}", ex.Message), ex);
+                var stackTraceIfMissing = ex.Message.IndexOf("Stack trace:", StringComparison.OrdinalIgnoreCase) >= 0
+                    ? string.Empty
+                    : StackTraceFormatter.GetExceptionStackTrace(ex);
+
+                OnErrorEvent(string.Format("Error reading instrument data with ProteoWizard: {0}; {1}", ex.Message, stackTraceIfMissing), ex);
+
                 return false;
             }
         }