Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional sort key as part of primary key #778

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Add optional sort key as part of primary key #778

merged 5 commits into from
Sep 19, 2024

Conversation

kookster
Copy link
Member

No description provided.

@kookster kookster requested review from farski and cavis and removed request for farski August 27, 2024 15:23
farski
farski reviewed Aug 27, 2024
View reviewed changes
db/dynamodb-global-table.yml Outdated Show resolved Hide resolved
db/dynamodb-global-table.yml Outdated Show resolved Hide resolved
db/dynamodb-global-table.yml Outdated Show resolved Hide resolved
@kookster kookster requested a review from farski August 28, 2024 20:41
cavis
cavis approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 i'm never 100% confident where AWS::NoValue will work out. But this looks good to me - worth trying out.

@cavis
Copy link
Member

cavis commented Aug 29, 2024

Oh, but prettier linting did fail. (I think the cfn-lint stuff is all ignorable right now).

@kookster
Copy link
Member Author

Oh, but prettier linting did fail. (I think the cfn-lint stuff is all ignorable right now).

apparently it didn't like the amount of indentation - fixed.

farski
farski approved these changes Aug 29, 2024
View reviewed changes
db/dynamodb-global-table.yml Outdated Show resolved Hide resolved
db/dynamodb-global-table.yml Outdated Show resolved Hide resolved
@kookster
Copy link
Member Author

This worked in staging

https://us-east-1.console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/stackinfo?filteringStatus=active&filteringText=&stackId=arn%3Aaws%3Acloudformation%3Aus-east-1%3A424798965986%3Astack%2Fstaging-dovetail-listener-frequency-ddb-global%2F5487fef0-76bd-11ef-9472-0e45891c840f&viewNested=true

I'm going to call it done, I'll make any necessary changes that might come up in testing in a new PR / commits

@kookster kookster merged commit 5b0cd97 into main Sep 19, 2024
3 of 4 checks passed
@kookster kookster deleted the feat/ddb_global_sort_key branch September 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farski farski farski approved these changes

@cavis cavis cavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kookster @cavis @farski