Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give scaler function access to regional prx-feed bucket #781

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Give scaler function access to regional prx-feed bucket #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spire/templates/apps-300A.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ Resources:
SharedRedisReplicationGroupEndpointAddress: !Ref SharedRedisReplicationGroupEndpointAddress
SharedRedisReplicationGroupEndpointPort: !Ref SharedRedisReplicationGroupEndpointPort
SharedGlueDatabaseName: !Ref SharedGlueDatabaseName
FeedsS3BucketArn: !Sub /prx/${EnvironmentTypeAbbreviation}/Spire/Dovetail-Feeder/us-east-1/s3-bucket-arn
FeedsS3BucketArn: !Sub /prx/${EnvironmentTypeAbbreviation}/Spire/Dovetail-Feeder/${AWS::Region}/s3-bucket-arn
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the dovetail-router.yml stack, this is only used in the s3:GetObject / s3:GetObjectVersion policy on the feed-scaler. So shouldn't hurt to change it.

AuguryHostname: !Ref AuguryHostname
FeederHostname: !Ref FeederHostname
DovetailCdnHostname: !Ref DovetailCdnHostname
Expand Down
Loading