Upgrade Router scaler function to Node.js 20 and AWS SDK v3 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavis
approved these changes
Sep 17, 2024
| @@ -940,15 +953,18 @@ Resources: | |||
| }; | |||
|
|
|||
| exports.handler = async (event) => { | |||
| console.log(JSON.stringify(event)); | |||
There was a problem hiding this comment.
Temporary for the "real world test run"?
There was a problem hiding this comment.
I like logging events in Lambdas so that if I ever need to run them manually there are good samples around. I can remove though, if you want.
| @@ -16,6 +16,7 @@ | |||
| "@aws-sdk/client-cloudwatch": "3.x", | |||
| "@aws-sdk/client-codebuild": "3.x", | |||
| "@aws-sdk/client-codepipeline": "3.x", | |||
| "@aws-sdk/client-dynamodb": "3.x", | |||
There was a problem hiding this comment.
So what is this package.json used for? Are you running the code for these functions locally somehow?
There was a problem hiding this comment.
Really just so that my IDE has type info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably needs at least one real-world test run. Some of the v3 SDK commands work a little differently than v2. I think I accounted for all of them, but worth checking.
Closes #733